Updating date-fns library from 1.x to 2.x #10848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelshaw
suggested changes
Feb 5, 2021
| // TODO: minStart, maxEnd | ||
| let params = {}; | ||
| if (start) { | ||
| let startDate = parseDateString(start); | ||
| if (startDate) { | ||
| // TODO: Replace with formatRFC3339 when date-fns is updated | ||
| params.start_time = format(addDays(startDate, 1), 'X'); | ||
| // converts to milliseconds, divide by 1000 to get epoch | ||
| params.start_time = getTime(startDate) / 1000; |
There was a problem hiding this comment.
Pretty sure we added days because there was some weirdness with UTC, but if the tests pass with this update we should be ok
chelshaw
approved these changes
Feb 8, 2021
| @@ -14,4 +17,31 @@ module('Integration | Helper | date-from-now', function(hooks) { | |||
| let result = dateFromNow([1481022124443], { addSuffix: true }); | |||
| assert.ok(result.includes(' ago')); | |||
| }); | |||
|
|
|||
| test('you can pass in UTC timestamp', function(assert) { | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update this library to take advantage of the new methods available in version 2.^ for the Database Secret Engine project.
Worked through the breaking changes according to the date-fns changelog, but also issues that came up in the failed test. For example, AM/PM from
Atoa.